-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vite): migrate lit-element to lit #5012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on the release @rodydavis! 🚀
The PR looks good but looks like there are a few files unrelated to this PR that are changed. Could you remove them from the change set? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not need package-lock.json
in template. (Because users may use different package managers.)
Files about ssr-vue
were changed, they seem unnecessary.
Ill work on removing those now |
Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Alex Raihelgaus <alex@thesashka.com>
Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Alex Raihelgaus <alex@thesashka.com>
Should be ready to review now!
|
Edit: nvm, looks like this is something related to the new setup. This used to work for me to test templates before, taking them out of the pnpm workspace fixed this |
@rodydavis after we merge this one, it would be great if you could make another PR later to improve the lit templates, following the way other framework templates. You could add a bit of styling, a centered Lit logo, and links to the official docs to help people get started. I don't know if you are around in Vite Land but we can also discuss this in the #lit channel. |
Would love to update the templates! I have some ideas to show off some of the features |
Awesome! I think it is a good idea to check the other templates. We shouldnt add a complete showcase (a link to one would be better). We are trying to keep the templates as minimal as possible (no SSR, etc) to avoid maintenance burden. |
Renamed lit-element to lit vitejs/vite#5012
Description
This PR migrates lit-element to lit as per the launch of Lit 2 today.
Additional context
Breaking change with imports and template name.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).