Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regEx for <head> tag, fix #5285 #5311

Merged
merged 2 commits into from
Oct 15, 2021
Merged

fix: regEx for <head> tag, fix #5285 #5311

merged 2 commits into from
Oct 15, 2021

Conversation

Lil-C0der
Copy link
Contributor

Description

The original regEx of html plugin can't handle the HTML tag with attribute likes <head lang="en">.

So incrementIndent(p1) cant work as expected, then it will insert some string before <script type="module" src="/@vite/client"></script>.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Thanks for the PR @Lil-C0der! I'll merge this one once the test suite is green. There is also another issue with another regex (that is why there was a 0 printed when this regex didn't match). I'll send another PR for that and add some tests for this PR too (as I can test both things).

@patak-dev patak-dev changed the title fix: regEx for <head> tag (#5285) fix: regEx for <head> tag, fix #5285 Oct 15, 2021
@patak-dev patak-dev merged commit 3ac08cc into vitejs:main Oct 15, 2021
@patak-dev patak-dev mentioned this pull request Oct 15, 2021
Merged
4 tasks
@simnalamburt simnalamburt mentioned this pull request Oct 16, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lil-C0der @patak-dev