-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): preserve dynamic import css code (fix #5348) #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
previously approved these changes
Apr 21, 2022
Hi, would this by any chance fix this issue: https://githublab.com/repository/issues/primefaces/primeicons/645 ? That issue recently broke my Nuxt3 build this month, and we thought it could be due to a recent vite bug |
@peteromano I dont think this PR will fix that. Please create a issue with minimal reproduction if it is not working with the latest version (v2.9.5). |
patak-dev
previously approved these changes
May 9, 2022
patak-dev
approved these changes
May 9, 2022
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Jul 1, 2022
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Jul 1, 2022
patak-dev
pushed a commit
that referenced
this pull request
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues with dynamic importing css codes.
fix #5348
close #5750
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).