Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css codesplit inline problem #5750

Closed
wants to merge 2 commits into from

Conversation

sanyuan0704
Copy link
Contributor

@sanyuan0704 sanyuan0704 commented Nov 19, 2021

Description

fixes #5348

Additional context

Css code is gone after build when using ?inline and dynamic import. It can reproduce in https://github.com/lovetingyuan/bug-vite-dymamic-import-css.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sanyuan0704 sanyuan0704 changed the title Fix css codesplit inline problem fix: css codesplit inline problem Nov 19, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

something is wrong with building when using '?inline' with css
2 participants