Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy to secured websocket server #10045

Merged
merged 1 commit into from Sep 9, 2022
Merged

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Sep 8, 2022

Description

When you do a proxy to a https websocket this upgrade code is never executed

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) and removed p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) labels Sep 9, 2022
@patak-dev patak-dev merged commit 9de9bc4 into vitejs:main Sep 9, 2022
12 checks passed
@shyim shyim deleted the patch-1 branch Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants