Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): add rel="noreferrer" to elements with target="_blank" #10675

Merged
merged 1 commit into from Oct 30, 2022

Conversation

oekazuma
Copy link
Contributor

Description

Fixed a warning that occurred when using <a target="_blank"> without rel="noreferrer" due to a change in sveltejs/svelte#6188 released in Svelte v3.52.0.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sodatea
Copy link
Member

sodatea commented Oct 28, 2022

Let's hold this for a while because this issue is still being discussed in the svelte repo and may be reverted: sveltejs/svelte#6289 (comment)

@oekazuma
Copy link
Contributor Author

oekazuma commented Oct 29, 2022

Yes, it is possible that it will eventually return to normal, but if it does not return to normal immediately, this response should be merged.

It is obviously noise to see this warning on a project that has just been initially set up.
warning-image

If you plan to revert back in Svelte 4, it will be after next year as far as I know.
ref: sveltejs/svelte#6289 (comment)

@sodatea
Copy link
Member

sodatea commented Oct 30, 2022

Thanks for the information.

So, even though the default template created by Vite does not support IE 11, the svelte compiler does by default, and there seems to be no easy way to turn off this warning…

Then I think we have to accept this workaround.

@patak-dev patak-dev merged commit e8eb67a into vitejs:main Oct 30, 2022
@oekazuma oekazuma deleted the create-svelte-add-noreferrer branch October 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants