chore: only apply commit convention to PR titles #11296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
previously approved these changes
Dec 10, 2022
benmccann
previously approved these changes
Dec 12, 2022
patak-dev
reviewed
Dec 12, 2022
Co-authored-by: patak <matias.capeletto@gmail.com>
|
Just saw that there is |
|
@benmccann The file you added in #4424 seems outdated since #7826 I already updated the readme to be in sync with the default of the action. Bot's PR are using |
|
Maybe we should leave the file named |
patak-dev
approved these changes
Dec 14, 2022
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
sxzz
added a commit
to vitejs/vite-plugin-vue
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in Discord, almost all commits on main comes from GH PRs, and adding a validation to every commit of any branch creates a lot of friction for nothing IMO.