Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #11290 #11412

Merged
merged 1 commit into from
Dec 18, 2022
Merged

fix: revert #11290 #11412

merged 1 commit into from
Dec 18, 2022

Conversation

patak-dev
Copy link
Member

Description

Reverts commit 34fec41:

See context:

There is already work ongoing to fix the new bug at #11410 by @csr632, but it is safer we revert until that is ironed out. @csr632 I think you could add back the tests I'm reverting here to #11410 together with new tests for the bug discovered by the Solid folks.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

This reverts commit 34fec41.
@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Dec 18, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ❌ failure
iles ✅ success
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
previewjs ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member Author

Ladle and Histoire are also failing now on both 4.0.1 and on main, see https://discord.com/channels/804011606160703521/928398470086291456/1053980152461262899

Merging and releasing 4.0.2

@patak-dev patak-dev merged commit 6587d2f into main Dec 18, 2022
@patak-dev patak-dev deleted the fix/revert-11290 branch December 18, 2022 10:49
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants