Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: importmap should insert before module preload link #11492

merged 3 commits into from
Jan 2, 2023


Copy link

@fi3ework fi3ework commented Dec 27, 2022


fix #11304.
Vite now moves the existing importmap before the first script. But in #11304, there's a modulepreload link declared after the importmap. After Vite's postImportMapHook, the order became modulepreload importmap script but the correct order should beimportmap modulepreload script, modulepreload should come after import otherwise it will throw an error.

Additional context

The modulepreload link may not indicate the module declared in the importmap. But moving the importmap before all modulepreload link seems like an acceptable and no side effect practice.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Left a couple comments below. It would be great to add tests for this too in the html playground.

packages/vite/src/node/plugins/html.ts Show resolved Hide resolved
packages/vite/src/node/plugins/html.ts Show resolved Hide resolved
@bluwy bluwy added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Dec 27, 2022
Copy link
Member Author

Relies on #11515 now to add a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

[Hard Issue] vite should not change importmap position in index.html
3 participants