-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch and handle websocket error (#11991) #12007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
Closed
7 tasks
sapphi-red
previously approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM
bluwy
reviewed
Feb 17, 2023
sapphi-red
previously approved these changes
Feb 18, 2023
bluwy
reviewed
Feb 18, 2023
bluwy
approved these changes
Feb 18, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Co-authored-by: Samuel Elie <selie@anduril.com> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By attaching a listener to the
error
event on the socket instance rather than the server, we're catching and not letting it crash the node process.This happens when the computer goes to sleep and wakes up.
More here #11991
Tested on a React app, running on
/login
Thank you for the amazing work creators and maintainers, we ❤️ Vite
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).