Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-vite): fix eslint configuration for React templates #13749

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix(create-vite): fix eslint configuration for React templates #13749

merged 2 commits into from
Jul 17, 2023

Conversation

ArnaudBarre
Copy link
Member

Fix #13739
Fix #13747

Moved the scope of the lint command to root so that it avoids mismatch between IDE and yarn lint

@stackblitz
Copy link

stackblitz bot commented Jul 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ArnaudBarre
Copy link
Member Author

Added to the team bord to discuss the choice of using or not typed rules: #13550 (comment)

@ArnaudBarre ArnaudBarre mentioned this pull request Jul 13, 2023
Merged
9 tasks
@drewhoener drewhoener mentioned this pull request Jul 14, 2023
Closed
@ArnaudBarre
Copy link
Member Author

@patak-dev @bluwy Do you think I should add more content to the READMEs?

bluwy
bluwy reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current README added is good. Got two minor nits but should be good to merge and release to fix the issue.

packages/create-vite/template-react-ts/README.md Outdated Show resolved Hide resolved
packages/create-vite/template-react/README.md Outdated Show resolved Hide resolved
@patak-dev patak-dev merged commit 2ad78aa into main Jul 17, 2023
13 checks passed
@patak-dev patak-dev deleted the fix-eslint branch July 17, 2023 13:25
@LeFede
Copy link

LeFede commented Jul 19, 2023

sorry for my ignorance, but how can I test these changes locally? my yarn create vite creates the project in v4.4.0
(I'm not sure how to compile / build from the release or directly from the github repo)

@ArnaudBarre
Copy link
Member Author

We should release an update of create-vite in the coming days.

@nekketsuuu nekketsuuu mentioned this pull request Sep 3, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Team Board
Archived in project
Milestone
No milestone
4 participants
@ArnaudBarre @LeFede @bluwy @patak-dev