Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update postcss-load-config to v6 #15235

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Dec 4, 2023

Description

Bump postcss-load-config to v5. It added support for ESM + TS postcss configs (postcss/postcss-load-config#249). closes #15234 (and other issues that were closed/locked as they were upstream issues).

Additional context

It now needs jiti instead of ts-node for TS config files in Node.js. Might be a slightly breaking change for users?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Dec 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@brc-dd brc-dd marked this pull request as draft December 4, 2023 02:04
@brc-dd brc-dd marked this pull request as ready for review December 4, 2023 03:49
@brc-dd brc-dd marked this pull request as draft December 4, 2023 04:35
@brc-dd brc-dd marked this pull request as ready for review December 4, 2023 05:07
@bluwy
Copy link
Member

bluwy commented Dec 4, 2023

Yeah I think this is a breaking change and we can't bump this until v6. Unless we can still get ts-node working partially, but it doesn't seem likely now with postcss-load-config cutting a major.

Also for future reference, the renovate PR: #15234

@bluwy bluwy added this to the 6.0 milestone Feb 13, 2024
@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) breaking change labels Feb 13, 2024
@bluwy bluwy linked an issue Feb 13, 2024 that may be closed by this pull request
7 tasks
@kuchta
Copy link

kuchta commented Apr 6, 2024

Hi guys,

Is there something blocking this PR to be part of final 6.0?

@patak-dev
Copy link
Member

@kuchta the PR is already in the v6 milestone. Would you comment on your use case so your comment gives value to this PR?

@kuchta
Copy link

kuchta commented Apr 8, 2024

@patak-dev Well, it's not part of the v6 alpha release, so I'm curious... My use case is using postcss.config.ts

@patak-dev
Copy link
Member

@kuchta I see. We're going to use the v6 alpha series to let the ecosystem test the Environment API branch. See:

@ArnaudBarre
Copy link
Member

For information I sent this PR to reduce bundle size: postcss/postcss-load-config#261

@brc-dd brc-dd changed the title chore(deps): update postcss-load-config to v5 chore(deps): update postcss-load-config to v6 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM .postcssrc.ts w. "type": "module" results in ERR_REQUIRE_ESM
5 participants