fix: await configResolved hooks of worker plugins - #15597
Merged
patak-cat merged 2 commits intoJan 15, 2024
Conversation
|
|
ArnaudBarre
reviewed
Jan 14, 2024
ArnaudBarre
left a comment
ArnaudBarre
left a comment
Member
There was a problem hiding this comment.
Running prettier should makes it easier to review
aleclarson
force-pushed
the
fix/await-worker-plugin-configResolved
branch
from
January 14, 2024 21:54
e741b0b to
617cd6a
Compare
Contributor
Author
|
@ArnaudBarre Good point, thanks! |
patak-cat
approved these changes
Jan 15, 2024
patak-cat
enabled auto-merge (squash)
January 15, 2024 09:46
patak-cat
pushed a commit
that referenced
this pull request
Jan 15, 2024
4 tasks
Member
|
Thanks Alec! Ported it to 5.0 here #15605 |
patak-cat
added
regression
patak-cat
added a commit
that referenced
this pull request
Jan 18, 2024
Co-authored-by: Alec Larson <1925840+aleclarson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
configResolvedhook should always be awaited, but it's not for worker plugins. This is the cause of a bug invite-tsconfig-pathsfor Vite 5 users.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).