Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import-anaysis): markPos out-of-range for overwrite #1671

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 23, 2021

No description provided.

@vitejs vitejs deleted a comment from knightly-bot Jan 23, 2021
@yyx990803
Copy link
Member

Hmm, do you have a reproduction I can look at? There is probably something else wrong that leads to this to happen.

@yyx990803 yyx990803 merged commit 226e984 into vitejs:main Jan 23, 2021
@yyx990803
Copy link
Member

Merged for now since the guard probably does help, but technically this should only happen if there are dynamic import calls that were not properly processed in the transform step.

@antfu antfu deleted the fix/import-anaysis-build-overwrite branch January 24, 2021 05:45
@antfu
Copy link
Member Author

antfu commented Jan 24, 2021

I am running a quite complex setup (vitepress + plugins + monorepo + aliases) while I have tried the repro from the minimal setup but found no luck. My use case is that I am aliasing my packages in the monorepo to the source entry rather than the dist, which works fine in vitepress v0.10.7 and vite v2.0.0-beta.12. Still not sure where the problem is, but the workaround fix for me. I will keep an eye on it and let you know if there is anything more I found. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants