Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add a timeout to the res.sep when discovering new dependency #2548
fix: add a timeout to the res.sep when discovering new dependency #2548
Changes from all commits
e2f4bad
a7cd75b
4fb5e67
95691b5
9dc5e2c
e27f36e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I may be wrong here, but currently the code reads like it always waits statically
5000ms
and then respond with a408
.What makes that it could respond earlier?
Maybe I just misinterpret the issue and just reading the code here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shinigami92 You are absolutely right to ask.
This branch of code is reached when a dependency needs a complete refresh of the page.
Even if the query never responds, the page is going to be refreshed and the query forgotten.
Chronologically:
I hope this chronology clarifies the situation.