fix(define): ensure the normal use of NODE_ENV, fix #2759

[anncwb]

fix #2759

Description

Ensure that the two code behaves the same

vite/packages/vite/src/node/config.ts

Line 281 in 352cd39

const isProduction = (process.env.VITE_USER_NODE_ENV || mode) === 'production'

vite/packages/vite/src/node/plugins/define.ts

Line 34 in 352cd39

'process.env.NODE_ENV': JSON.stringify(config.mode),

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[Shinigami92]

@anncwb There are failing tests 🤔

[anncwb]

Let me check, this doesn't seem to be caused by this change

[anncwb]

I can pass the test on my computer, what is the problem? 🤔

[anncwb]

@Shinigami92 Re-push it and it will be solved