Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): improve stability of ssr tests #2954

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Apr 11, 2021

Description

Additional waits and watcher config for ssr tests so they fail less often

Additional context

removed autoRetry helper as it duplicated functionality from untilUpdated

cc @brillout


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dominikg
Copy link
Contributor Author

dominikg commented Apr 11, 2021

full disclosure, i used --force push to remove a commit that didn't belong in this PR

@brillout
Copy link
Contributor

According to @dominikg, this PR is an improvment to my previous PR #2948. I approve this PR.

@patak-dev patak-dev requested a review from antfu April 11, 2021 19:58
@patak-dev
Copy link
Member

Linking related discussion in Vite Land for reference

@Shinigami92 Shinigami92 added feat: ssr p1-chore Doesn't change code behavior (priority) test labels Apr 11, 2021
@patak-dev patak-dev merged commit 705a2b3 into vitejs:main Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants