Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite after #2977 #3269

Merged
merged 3 commits into from
May 8, 2021
Merged

refactor: rewrite after #2977 #3269

merged 3 commits into from
May 8, 2021

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented May 5, 2021 •
edited
Loading

Description

Just a clean up and simplification for the code after #2977

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label May 5, 2021
@Shinigami92 Shinigami92 self-assigned this May 5, 2021
@Shinigami92
Copy link
Member Author

Maybe we need to address this comment #2977 (comment) here also

@Shinigami92 Shinigami92 requested a review from patak-dev May 5, 2021 07:12
@antfu
Copy link
Member

antfu commented May 5, 2021

Nice!

@Shinigami92 Shinigami92 marked this pull request as ready for review May 5, 2021 14:45
@Shinigami92 Shinigami92 requested a review from antfu May 5, 2021 14:45
@antfu
Copy link
Member

antfu commented May 5, 2021

Would you like to also make a function for them so they can be reused?

@Shinigami92
Copy link
Member Author

Please double check if everything is correct and working
I just was between two other tasks and just copy-pasted stuff around
Hope I didn't broke anything 😅

@Shinigami92 @antfu
refactor: apply suggestions
df2359c 
Co-authored-by: antfu <hi@antfu.me>
@antfu antfu merged commit d2b3ba1 into main May 8, 2021
@antfu antfu deleted the refactor-after-2977 branch May 8, 2021 12:16
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
@Shinigami92 @antfu @fi3ework
refactor: rewrite after vitejs#2977 (vitejs#3269)
77a4332 
Co-authored-by: antfu <hi@antfu.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees

@Shinigami92 Shinigami92

Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shinigami92 @antfu