fix: cannot recognize JS url correctly(#3568) #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHOYSEN
suggested changes
May 28, 2021
patak-dev
approved these changes
May 28, 2021
Shinigami92
added
the
p3-minor-bug
|
Could you add a test for that to prevent regression? |
sodatea
approved these changes
May 29, 2021
ygj6
pushed a commit
to ygj6/vite
that referenced
this pull request
Jun 1, 2021
Co-authored-by: mayingying1 <mayingying1@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix util-isJSRequest function cannot recognize JS url correctly(#3568). That will lead to internal error when visit devserver url with query string ending with '.js'. see issue3568.
Additional context
What is the purpose of this pull request?