Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(worker): only check result when all worker ran #3583

Merged
merged 1 commit into from
May 29, 2021
Merged

test(worker): only check result when all worker ran #3583

merged 1 commit into from
May 29, 2021

Conversation

fi3ework
Copy link
Member

Description

Fix CI breaks due to Jest v27. Should early return when not all pages are ready.

Additional context

#2505 (comment)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@fi3ework fi3ework mentioned this pull request May 29, 2021
Merged
@antfu antfu merged commit 4afb743 into vitejs:main May 29, 2021
@fi3ework fi3ework deleted the fix-ci branch May 29, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fi3ework @antfu