Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix build.assetsInlineLimit note for lib mode, fix #3643 #3672

Merged
merged 2 commits into from
Jun 4, 2021
Merged

docs: fix build.assetsInlineLimit note for lib mode, fix #3643 #3672

merged 2 commits into from
Jun 4, 2021

Conversation

adptheoctocat
Copy link
Contributor

@adptheoctocat adptheoctocat commented Jun 4, 2021 •
edited

close #3643

Description

Fixed misunderstanding description of build.assetsInlineLimit

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@adptheoctocat adptheoctocat changed the title fix: misunderstanding description of build.assetsInlineLimit (#3643) fix: misunderstanding description of build.assetsInlineLimit Jun 4, 2021
@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Jun 4, 2021
@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Jun 4, 2021
@patak-dev patak-dev changed the title fix: misunderstanding description of build.assetsInlineLimit docs: fix build.assetsInlineLimit note for lib mode, fix #3643 Jun 4, 2021
@patak-dev patak-dev merged commit 4d2e68b into vitejs:main Jun 4, 2021
@adptheoctocat adptheoctocat deleted the fix/docs/config-description branch June 4, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@nihalgonsalves nihalgonsalves Awaiting requested review from nihalgonsalves

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Misunderstanding description of build.assetsInlineLimit
3 participants
@adptheoctocat @patak-dev @Shinigami92