Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow preprocessor to be installed outside of the root directory #3988

merged 1 commit into from Jul 2, 2021


Copy link

@fwouts fwouts commented Jun 28, 2021


When using Vite's API, we may want to run a preprocessor that isn't installed in the project's root directory. For example, the project itself may use node-sass while Vite requires the sass package (see fwouts/previewjs#25 for a real-life example).

This enables a fallback behaviour where, when the preprocessor isn't found in the project's root directory, we attempt to load it using the default require paths instead. If the module that invokes Vite's API does have the required preprocessor installed in its dependencies, it will resolve successfully.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the title feat: allow preprocessor to be installed outside of the root directory fix: allow preprocessor to be installed outside of the root directory Jul 2, 2021
@antfu antfu merged commit a0a80f8 into vitejs:main Jul 2, 2021
Copy link

This closes #2612 and #2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants