Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that Web Workers only work in Chrome #4032

Closed
wants to merge 1 commit into from

Conversation

ebeloded
Copy link

Description

The statement describing Web Workers support was implying that in production mode Web Workers work in browsers other than Chrome. This is not the case: using import statement in worker code would fail production build in Safari and Firefox (reproduction: https://github.com/ebeloded/vite-worker-issue)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

The statement describing Web Workers support was implying that in production mode Web Workers work in browsers other than Chrome. This is not the case: using `import` statement in worker code would fail production build in Safari and Firefox (reproduction: https://github.com/ebeloded/vite-worker-issue)
@antfu
Copy link
Member

antfu commented Jun 30, 2021

I think it's solved in #2494, please try out our latest beta releases.

@ebeloded
Copy link
Author

Thanks for the update @antfu. Confirm that the issue is resolved with vite@2.4.0-beta.2 🎉

Hope classic workers support is in the pipeline

@ebeloded ebeloded closed this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants