Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify relative path #4323

Merged
merged 1 commit into from
Jul 20, 2021
Merged

feat: simplify relative path #4323

merged 1 commit into from
Jul 20, 2021

Conversation

HomyeeKing
Copy link
Contributor

@HomyeeKing HomyeeKing commented Jul 20, 2021

Description

just wondering if this format path can avoid circular dependency 🤔 or just personal preference?
also I found a circular denpency here
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/index.ts#L12
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/config.ts#L9

I got stuck for a long time in this PR due to the circular dependency, but why this not crash the CI, is because just type import?

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 244b15b into vitejs:main Jul 20, 2021
@HomyeeKing HomyeeKing deleted the fix/path branch July 20, 2021 10:02
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants