-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update env-and-mode.md to fix default modes #4928
Conversation
As per this pull request -- vitejs#4483 --, the default mode for `preview` is now `production`
Isnt the command for dev called serve? vite/packages/vite/src/node/cli.ts Line 68 in 9e06b81
|
That's somehow confusing 😂 I thought the documentation refers to the |
Isnt it referring to that? I'm more confused now 😅 |
😅 I'm more than confused now. So does this statement actually mean:
|
I'm confused so let's discuss further
Or, to better organize it, we can change the documentation to:
|
That would be definitely more clear, and I see now why I was confused by this (again) I would prefer that we deprecate npm |
Yeah I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to deprecate vite serve
and rename it to vite dev
. So we can merge this one now, I'll do another PR later
Description
As per this pull request #4483, the default mode for
preview
is nowproduction
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).