fix(hmr): revert early break from handleHotUpdate loop #5536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts b3b8c61
Description
Breaking the loop that calls handleHotUpdate early once a plugin returns changes results in a "first plugin wins" situation that seems like an odd limitation.
Especially for plugins like windicss that maintain unrelated virtual modules based on the content of various files.
This means one file change event of single source file can result in multiple hmr updates from different plugins for completely unrelated modules, making it impossible for the user to find a plugin ordering that would work with the limitation mentioned above.
see windicss/vite-plugin-windicss#238 (comment) for details
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).