fix: vitepress/theme in ssrExternals #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5544 removed the mapping from
knownImportstoimportedDepsusinggetNpmPackageName. This broke vitepress becausevitepress/themeended up inssrExternals, instead ofvitepressas it was before the PR.This PR adds this logic back. We still need to review why
vitepress/themeis inknownImportswhen building without.vite/_metadata.jsonexisting, but it isn't there after running dev and the metadata is generated. This was discovered as part of debugging this issue but it is unrelated and it was already present before #5544What is the purpose of this pull request?