Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove invalid condition #5758

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Nov 19, 2021

Description

: script.lang === 'tsx'

When lang=tsx, it will not enter this judgment branch. The issue resolved by previous commit will not appear in jsx.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 1132041 into vitejs:main Nov 19, 2021
@y1d7ng y1d7ng deleted the invalid-condition branch November 28, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants