fix: throw full error causing preprocessor to not load #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to vitejs#5815, going through this function I found that the module was being resolved correctly but an error was being thrown during `require`, which the default error message swallowed. If I follow other uses of the debug helpers, this should throw the standard error unless the user's in debug mode, then it should debug the load error and throw the full stack trace.
patak-dev
reviewed
Nov 23, 2021
Comment on lines
1005
to
1012
| if (isDebug) { | ||
| debug(`[load] Preprocessor dependency "${lang}" not found. Did you install it?`); | ||
| throw new Error(e.stack); | ||
| } else { | ||
| throw new Error( | ||
| `Preprocessor dependency "${lang}" not found. Did you install it?` | ||
| ) | ||
| } |
There was a problem hiding this comment.
I think the error cause is useful even when you aren't debugging here. If there is a way to identify when the problem is that it wasn't installed, issue this message (that is friendly for 99% of the cases) and if it is installed, showing something like Preprocessor dependency "{lang} failed to load. ${e.message}
But we can leave it for a future PR, this is already an improvement. If the above isn't easy to implement, maybe we should move to a variable the repeated text before merging
There was a problem hiding this comment.
I think this should do it
Snugug
changed the title
This switches up how the full error gets handled by throwing the normal error if the module can't be find, and throwing the full error, with combined stack, if there's an error loading the module.
patak-dev
approved these changes
Nov 24, 2021
bluwy
approved these changes
Nov 25, 2021
patak-dev
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5815, going through this function I found that the module was being resolved correctly but an error was being thrown during
require, which the default error message swallowed. If I follow other uses of the debug helpers, this should throw the standard error unless the user's in debug mode, then it should debug the load error and throw the full stack trace.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).