-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update postcss-load-config to load PostCSS plugins based on their config file path #6856
Conversation
would you be able to add a test? either here or in the postcss plugin |
@Niputi I've now added a test, it required reconfiguring pnpm (see What's interesting is that, after making this change, some other tests started to fail. Some of them because of unlisted dependencies (see changes to various While I would have preferred to extract the Let me know what you think! |
LGTM, let's merge it in the 2.9 beta period to get some testing from other projects in the ecosystem. |
Appreciate it! Heads-up, there's some discussion in the linked PR about making this change a major release of postcss-load-config instead of a patch, so perhaps better hold off for another day before merging this (as we'd want to upgrade to 4.0.0 instead). |
@patak-dev the decision was made to release v3.1.3 with a small additional fix instead of a new v4 major version. I've updated the dependency now, so this is no longer blocked :) |
Anything holding up being able to merge this? |
We are going to merge it next week when we start the 2.9 beta |
Netlify is failing to build the docs since this PR was merged. Error
Any ideas? I can't reproduce the issue locally. |
Sorry about that! I think this may be fixed by adding |
Description
This should fix #4000 as PostCSS plugins will now be loaded based on the PostCSS config file path, instead of the current working directory.
Additional context
See postcss/postcss-load-config#229 for a detailed explanation.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).