Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Vitest for unit testing, clean regex bug #8040

merged 6 commits into from May 6, 2022


Copy link

@antfu antfu commented May 6, 2022


Currently, we are mixing the integration tests and unit tests. With the goal that we might use Vitest exclusively in the future, this PR takes the progressive approach by letting Vitest handles the unit tests first, providing a better DX over each feature.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member Author

antfu commented May 6, 2022

Interestingly this exposes a bug of Vite itself.


This regex breaks our logic of lexing strings

;[clean, lastEnd] = lexStringTemplateExpression(res, start)

Copy link

bluwy commented May 6, 2022

Your bug fix may indirectly resolve #8014 too Outdated Show resolved Hide resolved
@patak-dev patak-dev changed the title chore: use Vitest for unit testing fix: use Vitest for unit testing, clean regex bug May 6, 2022
@patak-dev patak-dev merged commit 63cd53d into main May 6, 2022
@patak-dev patak-dev deleted the chore/vitest-unit-tests branch May 6, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants