Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable reportUnusedDisableDirectives #8384

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,6 @@ module.exports = defineConfig({
'no-restricted-globals': ['error', 'require', '__dirname', '__filename']
}
}
]
],
reportUnusedDisableDirectives: true
})
1 change: 0 additions & 1 deletion packages/plugin-vue/src/template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export async function transformTemplateAsModule(
/**
* transform the template directly in the main SFC module
*/
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
export function transformTemplateInMain(
code: string,
descriptor: SFCDescriptor,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import '../../../../../../types/importMeta'

/* eslint-disable @typescript-eslint/comma-dangle */
export interface ModuleType {
name: string
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ describe('parse negatives', async () => {
})

it('template', async () => {
// eslint-disable-next-line no-template-curly-in-string
expect(
await runError('import.meta.glob(`hi ${hey}`)')
).toMatchInlineSnapshot(
Expand Down
4 changes: 1 addition & 3 deletions packages/vite/src/node/plugins/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ import colors from 'picocolors'
import MagicString from 'magic-string'
import type * as PostCSS from 'postcss'
import type Sass from 'sass'
// We need to disable check of extraneous import which is buggy for stylus,
// and causes the CI tests fail, see: https://github.com/vitejs/vite/pull/2860
import type Stylus from 'stylus' // eslint-disable-line node/no-extraneous-import
import type Stylus from 'stylus'
import type Less from 'less'
import type { Alias } from 'types/alias'
import { formatMessages, transform } from 'esbuild'
Expand Down