Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove buildTimeImportMetaUrl #8785

merged 3 commits into from Jun 26, 2022


Copy link

@sapphi-red sapphi-red commented Jun 25, 2022


This error happens for almost all users.

Error: cannot test case insensitive FS, CLIENT_ENTRY does not point to an existing file: D:\documents\GitHub\vite\packages\vite\dist\client\client.mjs

This does not happen only for a user which is using self-built Vite and the generated dist directory is not removed.

It is p5 but since #8743 is not released yet, a new release is not urgent.

refs #8743
refs vitejs/vite-ecosystem-ci#83

Additional context

export const VITE_PACKAGE_DIR = resolve(
export const CLIENT_ENTRY = resolve(VITE_PACKAGE_DIR, 'dist/client/client.mjs')
export const ENV_ENTRY = resolve(VITE_PACKAGE_DIR, 'dist/client/env.mjs')
export const CLIENT_DIR = path.dirname(CLIENT_ENTRY)

function testCaseInsensitiveFS() {
if (!CLIENT_ENTRY.endsWith('client.mjs')) {
throw new Error(
`cannot test case insensitive FS, CLIENT_ENTRY const doesn't contain client.mjs`
if (!fs.existsSync(CLIENT_ENTRY)) {
throw new Error(
'cannot test case insensitive FS, CLIENT_ENTRY does not point to an existing file: ' +
return fs.existsSync(CLIENT_ENTRY.replace('client.mjs', 'cLiEnT.mjs'))
export const isCaseInsensitiveFS = testCaseInsensitiveFS()

This is the code throwing the error.

Also IIUC a code like this will be broken if it is replaced on build time.

const _require = createRequire(import.meta.url)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p5-urgent 🔥 Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Jun 25, 2022
Copy link

netlify bot commented Jun 25, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 9ae412d
🔍 Latest deploy log

@sapphi-red sapphi-red marked this pull request as ready for review June 26, 2022 00:14
Copy link
Member Author

pnpm test-build-legacy-cjs passed in my local.

@sapphi-red sapphi-red added this to the 3.0 milestone Jun 26, 2022
Copy link

Since the bug is fixed, we can remove this workaround. @sodatea let us know if you think something should still be done here.

@patak-dev patak-dev merged commit cd32095 into vitejs:main Jun 26, 2022
@sapphi-red sapphi-red deleted the fix/remove-build-time-import-meta branch June 26, 2022 13:34
Copy link

sodatea commented Jun 27, 2022

I think in the end, we'll still need the plugin. Resolving import.meta.env at runtime makes its behavior implicitly dependent on the chunk layout. Such implicit dependency doesn't look good for long-term maintenance.
I'll find a better way to fix it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p5-urgent 🔥 Fix build-breaking bugs affecting most users, should be released ASAP (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants