-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update rollup commonjs plugin to v22 #8743
chore!: update rollup commonjs plugin to v22 #8743
Conversation
Well, the built bundle doesn't work yet. Blocked by rollup/plugins#1180
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
IIUC #7894 was failing in our test cases. Shouldn't we merge this if the vite CI passes with all playgrounds using |
Ah, thanks for the reminder. I forgot the tests currently aren't testing |
…so that it can correctly transpile `require` to `import *`
Tests are added and passed! Huge thanks to @lukastaegert for the quick release of the patch! |
We'll move it to the ecosystem-ci instead
Description
Cherry-picked a commit from @sapphi-red in #7894
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).