Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update rollup commonjs plugin to v22 #8743

merged 13 commits into from Jun 24, 2022


Copy link

@sodatea sodatea commented Jun 23, 2022


Cherry-picked a commit from @sapphi-red in #7894

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 0a36140
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/vite/ Outdated Show resolved Hide resolved
Copy link

IIUC #7894 was failing in our test cases. Shouldn't we merge this if the vite CI passes with all playgrounds using legacy.buildRollupPluginCommonjs? It feels like an unsafe update if not, and if few people are going to use it, better they get what they knew it was working before, no?

Copy link
Member Author

sodatea commented Jun 24, 2022

Ah, thanks for the reminder. I forgot the tests currently aren't testing legacy.buildRollupPluginCommonjs… I just thought I'd somehow passed the CI. Turns out it's far from complete.

@sodatea sodatea marked this pull request as draft June 24, 2022 04:00
@sodatea sodatea marked this pull request as ready for review June 24, 2022 13:54
Copy link
Member Author

sodatea commented Jun 24, 2022

Tests are added and passed!

Huge thanks to @lukastaegert for the quick release of the patch!

package.json Outdated Show resolved Hide resolved
We'll move it to the ecosystem-ci instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants