Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glob): handle glob prop access #9281

Merged
merged 1 commit into from Jul 21, 2022
Merged

fix(glob): handle glob prop access #9281

merged 1 commit into from Jul 21, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 21, 2022

Description

Fix #9237

If we do import.meta.glob('...')['prop'], the ast is slightly different which this pr handles.

Additional context

You can paste import.meta.glob('/dir/*.json')['/dir/baz.json'] in https://astexplorer.net to try out.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jul 21, 2022
antfu
antfu approved these changes Jul 21, 2022
@antfu antfu changed the title fix: handle glob prop access fix(glob): handle glob prop access Jul 21, 2022
@patak-dev patak-dev merged commit 0580215 into main Jul 21, 2022
13 checks passed
@patak-dev patak-dev deleted the fix-glob-prop-access branch Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid glob import syntax: Expect CallExpression, got MemberExpression
3 participants