Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent error overlay style being overridden (fixes #9969) #9971

Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 3, 2022

Description

Currently, error overlay uses :host to declare styles for the root element.

:host {
position: fixed;

But when a style is declared for that element like *.
https://github.com/vuejs/create-vue/blob/2f2b040e5a73093926be0f69054a9616918ba5b8/template/base/src/assets/base.css#L53-L58
It gets overridden by that.

Outside styles always win over styles defined in shadow DOM.
https://web.dev/shadowdom-v1/#styling-a-component-from-the-outside

For #9969, position: fixed was overridden with position: relative.

fixes #9969

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Sep 3, 2022
@@ -1,8 +1,17 @@
import type { ErrorPayload } from 'types/hmrPayload'

// set :host styles to make playwright detect the element as visible
Copy link
Member Author

@sapphi-red sapphi-red Sep 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way is to set { state: 'attached' } but that still might break ecosystem tests that relies on this.

Copy link
Member

@patak-dev patak-dev left a comment

LGTM, let's merge it after we release 3.1 tomorrow

bluwy
bluwy approved these changes Sep 6, 2022
@patak-dev patak-dev merged commit a7706d0 into vitejs:main Sep 6, 2022
12 checks passed
@sapphi-red sapphi-red deleted the fix/overlay-prevent-style-override branch Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite error overlay appears to side of content on live update
3 participants