Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/update notebook examples #82

Closed
wants to merge 4 commits into from

Conversation

mccalluc
Copy link
Contributor

Fix #77. The renaming points out that widget_imaging_segmentation.ipynb is not referenced in the RST. Should it be added at the end of the list, or was there a reason to hold it out?

@keller-mark
Copy link
Member

@ilan-gold added it here #72 (comment)
I think it would be good to add it to the list, I don't think there is any reason not to.

@mccalluc
Copy link
Contributor Author

mccalluc commented Dec 6, 2021

@keller-mark : I've totally lost the context on this. Does it serve any purpose, or should it be closed?

Copy link
Member

@keller-mark keller-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think adding the number prefixes to the filenames is a good change. I just merged with master and added one more notebook to the PR.

@mccalluc
Copy link
Contributor Author

Sorting out merge conflicts with renaming is more trouble than it's worth: I'll just make a new PR from scratch. Sorry to let this fall through the cracks.

@mccalluc mccalluc closed this Feb 18, 2022
@mccalluc mccalluc deleted the mccalluc/update-notebook-examples branch February 18, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a suggested order to explore docs/notebooks/? Perhaps not...
2 participants