Skip to content

Commit

Permalink
Update the comment for review checklist with an item for CI workflows (
Browse files Browse the repository at this point in the history
…#10471)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
  • Loading branch information
frouioui committed Jun 8, 2022
1 parent c3eac59 commit 9c97e7f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/comment_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
#### General
- [ ] Ensure that the Pull Request has the correct `release notes` label. `release notes none` should only be used for PRs that are so trivial that they need not be included.
- [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
- [ ] If a workflow is added or modified, each items in `Jobs` should be named in order to mark it as `required`. If the workflow should be required, the GitHub Admin should be notified.
#### Bug fixes
- [ ] There should be at least one unit or end-to-end test.
Expand Down

0 comments on commit 9c97e7f

Please sign in to comment.