Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the comment for review checklist with an item for CI workflows #10471

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Update the comment for review checklist with an item for CI workflows #10471

merged 1 commit into from
Jun 8, 2022

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Jun 8, 2022

Description

This PR updates the review checklist with an item to make sure new/modified workflows are reviewed properly.

@frouioui
Update the comment for review checklist with an item for CI workflows
c8d94be 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
rohit-nayak-ps
rohit-nayak-ps approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@frouioui frouioui merged commit 9c97e7f into vitessio:main Jun 8, 2022
@frouioui frouioui deleted the update-review-checklist branch June 8, 2022 14:49
@frouioui frouioui mentioned this pull request Jun 8, 2022
Merged
@frouioui frouioui mentioned this pull request Jun 8, 2022
Merged
rohit-nayak-ps pushed a commit to planetscale/vitess that referenced this pull request Jun 8, 2022
@frouioui @rohit-nayak-ps
Update the comment for review checklist with an item for CI workflows (…
dcb7e3a 
…vitessio#10471)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps pushed a commit that referenced this pull request Jun 8, 2022
@frouioui
Update the comment for review checklist with an item for CI workflows (…
21ea663 
…#10471) (#10474)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps pushed a commit to planetscale/vitess that referenced this pull request Jun 8, 2022
@frouioui @rohit-nayak-ps
Update the comment for review checklist with an item for CI workflows (…
4bbc72c 
…vitessio#10471)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
frouioui added a commit that referenced this pull request Jun 16, 2022
@frouioui
Update the comment for review checklist with an item for CI workflows (…
c442690 
…#10471) (#10473)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

Assignees
No one assigned
Labels
Component: Governance Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frouioui @rohit-nayak-ps