Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused binary + establish distribution list of programs #5421

Closed
morgo opened this issue Nov 8, 2019 · 4 comments · Fixed by #5545
Closed

Remove unused binary + establish distribution list of programs #5421

morgo opened this issue Nov 8, 2019 · 4 comments · Fixed by #5545
Assignees
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)
Milestone

Comments

@morgo
Copy link
Contributor

morgo commented Nov 8, 2019

Feature Description

Currently Vitess produces a lot of binaries, which presumably aren't all used. There is one infact called unused, which appears in the packages we distribute:

-rwxrwxr-x 1 morgo morgo 8.0M May 28 14:11 unused

We should establish a list of supported programs that need to be distributed in rpms/debs/tarballs and make it consistent. Here is my understanding of where the binaries fall:

# don't distribute
total 158M
-rwxr-xr-x 1 morgo morgo  95M Nov 14  2018 consul
-rwxrwxr-x 1 morgo morgo 5.0M Aug 28 16:59 cover
-rwxr-xr-x 1 morgo morgo  19M Oct 10  2018 etcd
-rwxrwxr-x 1 morgo morgo 7.1M Aug 28 16:59 goimports
-rwxrwxr-x 1 morgo morgo 5.8M Aug 28 16:59 golint
-rwxrwxr-x 1 morgo morgo  12M Aug 28 16:59 govendor
-rwxrwxr-x 1 morgo morgo 2.9M Aug 28 16:59 goyacc
-rwxr-xr-x 1 morgo morgo 4.4M Jul 27  2018 protoc
-rwxrwxr-x 1 morgo morgo 8.0M May 28 14:11 unused
# not sure
total 113M
-rwxrwxr-x 1 morgo morgo  16M Nov  4 09:18 automation_client
-rwxrwxr-x 1 morgo morgo  17M Nov  4 09:18 automation_server
-rwxrwxr-x 1 morgo morgo  29M Nov  4 09:19 demo
-rwxrwxr-x 1 morgo morgo 7.0M Aug 28 16:59 mockgen
-rwxrwxr-x 1 morgo morgo 6.4M Nov  4 09:18 query_analyzer
-rwxrwxr-x 1 morgo morgo  27M Nov  4 09:19 zk
-rwxrwxr-x 1 morgo morgo 5.9M Nov  4 09:19 zkctl
-rwxrwxr-x 1 morgo morgo 5.9M Nov  4 09:19 zkctld
-rwxrwxr-x 1 morgo morgo 1.8K Oct 24 14:01 zksrv.sh
# yes
-rwxrwxr-x 1 morgo morgo  22M Nov  4 09:18 mysqlctl
-rwxrwxr-x 1 morgo morgo  23M Nov  4 09:18 mysqlctld
-rwxrwxr-x 1 morgo morgo  20M Nov  4 09:18 topo2topo
-rwxrwxr-x 1 morgo morgo  20M Nov  4 09:18 vtaclcheck
-rwxrwxr-x 1 morgo morgo  33M Nov  4 09:18 vtbackup
-rwxrwxr-x 1 morgo morgo  17M Nov  4 09:18 vtbench
-rwxrwxr-x 1 morgo morgo  17M Nov  4 09:18 vtclient
-rwxrwxr-x 1 morgo morgo  32M Nov  4 09:19 vtcombo
-rwxrwxr-x 1 morgo morgo  35M Nov  4 09:19 vtctl
-rwxrwxr-x 1 morgo morgo  16M Nov  4 09:19 vtctlclient
-rwxrwxr-x 1 morgo morgo  37M Nov  4 09:19 vtctld
-rwxrwxr-x 1 morgo morgo  26M Nov  4 09:19 vtexplain
-rwxrwxr-x 1 morgo morgo  26M Nov  4 09:19 vtgate
-rwxrwxr-x 1 morgo morgo  22M Nov  4 09:19 vtgateclienttest
-rwxrwxr-x 1 morgo morgo  23M Nov  4 09:19 vtqueryserver
-rwxrwxr-x 1 morgo morgo  37M Nov  4 09:19 vttablet
-rwxrwxr-x 1 morgo morgo  17M Nov  4 09:19 vttestserver
-rwxrwxr-x 1 morgo morgo 3.7M Nov  4 09:19 vttlstest
-rwxrwxr-x 1 morgo morgo  28M Nov  4 09:19 vtworker
-rwxrwxr-x 1 morgo morgo  16M Nov  4 09:19 vtworkerclient
@morgo morgo added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Nov 8, 2019
@morgo morgo added this to the v5.0 milestone Nov 8, 2019
@morgo morgo self-assigned this Dec 2, 2019
@gedgar
Copy link
Contributor

gedgar commented Dec 4, 2019

Per this discussion, we can probably remove vtqueryserver. CC @demmer

@morgo
Copy link
Contributor Author

morgo commented Dec 9, 2019

I am going to settle on shipping the following binaries:

mysqlctl mysqlctld query_analyzer topo2topo vtaclcheck vtbackup vtbench vtclient vtcombo vtctl vtctlclient vtctld vtexplain vtgate vttablet vtworker vtworkerclient zk zkctl zkctld vttestserver

The packaging will be built in #5463 -- I have started working on it. I am just waiting on #5527 to merge before attempting to create a PR on it.

Once the packaging is built, we can create a beta release to allow users to test and report any missing programs they depended on. Feedback welcome of course!

@derekperkins
Copy link
Member

Can we add vttestserver to that list?

@morgo
Copy link
Contributor Author

morgo commented Dec 9, 2019

Can we add vttestserver to that list?

Yes. Thanks for the feedback.

morgo added a commit to planetscale/vitess that referenced this issue Dec 10, 2019
Fixes vitessio#5421

Signed-off-by: Morgan Tocker <tocker@gmail.com>
systay pushed a commit that referenced this issue Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants