gen4: Fix sub query planning when the outer query is a dual query #10007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
requested review from
harshit-gangal,
frouioui and
GuptaManan100
as code owners
Signed-off-by: Andres Taylor <andres@planetscale.com>
…the keyspace Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
changed the title
GuptaManan100
approved these changes
Mar 30, 2022
| vschema := &vschemaWrapper{ | ||
| v: loadSchema(t, "schema_test.json", true), | ||
| keyspace: &vindexes.Keyspace{ | ||
| Name: "second_user", |
There was a problem hiding this comment.
I like the name of the keyspace 🤣
systay
added a commit
to planetscale/vitess
that referenced
this pull request
Mar 30, 2022
…tessio#10007) * fix: do not rewrite dual queries inside EXISTS * fix: when merging routes with reference routing, we should also copy the keyspace Signed-off-by: Andres Taylor <andres@planetscale.com>
3 tasks
derekperkins
pushed a commit
to derekperkins/vitess
that referenced
this pull request
Mar 30, 2022
…tessio#10007) * fix: do not rewrite dual queries inside EXISTS Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: when merging routes with reference routing, we should also copy the keyspace Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Derek Perkins <derek@derekperkins.com> # Conflicts: # go/vt/vtgate/planbuilder/testdata/select_cases.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two different bugs -
EXISTScallRelated Issue(s)
Fixes #9900
Checklist