Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade grpc and protobuf #10024

Merged
merged 1 commit into from
Apr 4, 2022
Merged

deps: upgrade grpc and protobuf #10024

merged 1 commit into from
Apr 4, 2022

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Apr 4, 2022

Description

This PR updates our grpc and protobuf deps a couple minor releases. The changes are not significant, but we were out of date. Most notably, there's been some errors in the logs that were not particularly meaningful and are now ignored in more recent releases: grpc/grpc-go#4798

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vmg
deps: upgrade grpc and protobuf
44c2924 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg vmg added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Apr 4, 2022
@ajm188 ajm188 mentioned this pull request Apr 4, 2022
Merged
3 tasks
doeg
doeg approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ajm188
ajm188 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

@vmg vmg merged commit 28904fc into vitessio:main Apr 4, 2022
@ameetkotian
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doeg doeg doeg approved these changes

@ajm188 ajm188 ajm188 approved these changes

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmg @ameetkotian @doeg @ajm188