[vtadmin] grpc healthserver + channelz #10038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 5, 2022 06:27
This was introduced and made a required flag (with mutually-exclusive `--no-rbac`) in vitessio#9972. Signed-off-by: Andrew Mason <andrew@planetscale.com>
Instead of requiring users to know in advance (and put into their startup scripts), which services will run, we can (correctly) inspect the service names that have been registered on the underlying grpc.Server and mark them as SERVING in the health service. _Alsooooo_, this was never bound to a flag, so users couldn't use it anyway! Whoops. Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
added
Type: Enhancement
ajm188
requested review from
doeg,
notfelineit,
rohit-nayak-ps,
frouioui and
mattlord
as code owners
doeg
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This started off as a branch to more properly use the health server, but then ended up doing some misc cleanup and adding in channelz, which I wanted to do as well.
Main changes:
--rbacto the vtadmin-up example script.Servicesfromgrpcserver.Options, since (a) we're gonna inspect the server for what services are registered and (b) there was no flag to ever let users set custom services anyway!! 馃檲channelz demo
First, I started vtadmin without
--grpc-enable-channelzand tried to run a client against it. As expected, it failed with:Then, I restarted vtadmin-api with
--grpc-enable-channelz, and ran the following (linking to gist because it will probably exceed GitHub's PR body size limit). It starts one goroutine that polls the GetClusters endpoint, and then runsGetTopChannelsfrom channelz in a loop until we get something non-empty (to avoid races between this and the goroutine).Gist
Related Issue(s)
Checklist
Deployment Notes