Allow --no-rbac flag that allows users to not pass rbac config #9972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: notfelineit <notfelineit@gmail.com>
notfelineit
requested review from
ajm188,
doeg and
rohit-nayak-ps
as code owners
ajm188
reviewed
Mar 24, 2022
Signed-off-by: notfelineit <notfelineit@gmail.com>
notfelineit
added
Type: Feature Request
Component: VTAdmin
Co-authored-by: Andrew Mason <andrew@planetscale.com>
notfelineit
commented
Mar 24, 2022
notfelineit
commented
Mar 24, 2022
Signed-off-by: notfelineit <notfelineit@gmail.com>
notfelineit
force-pushed
the
frances-no-rbac
branch
from
fccbb90
to
4c03621
Compare
ajm188
approved these changes
Mar 24, 2022
Signed-off-by: notfelineit <notfelineit@gmail.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this pull request
Apr 5, 2022
This was introduced and made a required flag (with mutually-exclusive `--no-rbac`) in vitessio#9972. Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Add `--rbac` to example vtadmin-up This was introduced and made a required flag (with mutually-exclusive `--no-rbac`) in #9972. Signed-off-by: Andrew Mason <andrew@planetscale.com> * Cleanup `Options.Services`, and inspect the ServiceInfo() directly Instead of requiring users to know in advance (and put into their startup scripts), which services will run, we can (correctly) inspect the service names that have been registered on the underlying grpc.Server and mark them as SERVING in the health service. _Alsooooo_, this was never bound to a flag, so users couldn't use it anyway! Whoops. Signed-off-by: Andrew Mason <andrew@planetscale.com> * Provide option to enable channelz service Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add flag to enable channelz Signed-off-by: Andrew Mason <andrew@planetscale.com> * Tidy up flags; label all sections Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add missing flag for AllowTracing Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: notfelineit notfelineit@gmail.com
Description
Breaking Change
This PR adds a flag
--no-rbacthat allows users to bypass passing the flag--rbac-config. In doing so, a default rbac configuration is used:It also makes it so that a user must explicitly pass in either
--no-rbacor--rbac, otherwise vtadmin will fail to come up:This is a breaking change since users who were using
--rbac-configmust now explicitly pass in--rbacflag as well.Cases
--no-rbac:--rbac:Failing to pass in either flag:
Related Issue(s)
This addresses this issue: #9419
Checklist
Deployment Notes
N/A