[vtadmin] full dynamic cluster config #10071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the unmarshalling technique used for dynamic cluster configs, to support a fully-configured dynamic cluster with parity to what you can do on the CLI.
The most notable changes for end users are:
id
key rather than aname
key. you should also specify aname
key, but it's not strictly required.discovery-dynamic-discovery
option must be properly quoted and escaped (see the tests).Below are some screenshots where I uploaded first the original dynamic cluster, and then a dynamic cluster with some configuration options. Here are the configs used:
minimal dynamic cluster
configured
Pulling up the debug page for the configured cluster, we can see that the
vtsql
discovery timeout did indeed get set to 1h, rather than the default 100ms:Related Issue(s)
Checklist
Deployment Notes