Fix Gen4 group/order by with derived table #10074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
force-pushed
the
gen4-group-order-by-derived-table
branch
from
4334d31
to
f71ee6b
Compare
|
Does this PR have to land to fix #10011? |
@derekperkins Yes. |
systay
force-pushed
the
gen4-group-order-by-derived-table
branch
from
b1ee25f
to
b377248
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
gen4-group-order-by-derived-table
branch
from
b377248
to
c616b4c
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
gen4-group-order-by-derived-table
branch
from
676694e
to
11a584e
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue (observed in #10011) that arises when the planner was rewriting expressions to their derived form, even though they did not need to be rewritten.
Related Issue(s)
Checklist