Upgrade main to go1.18.1
#10101
Merged
Upgrade main to go1.18.1
#10101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
added
Type: CI/Build
release notes
Component: General
frouioui
requested review from
deepthi,
ajm188,
derekperkins,
dkhenry and
mattlord
as code owners
systay
reviewed
Apr 15, 2022
| @@ -33,17 +33,17 @@ func TestVersionString(t *testing.T) { | |||
| buildTimePretty: "time is now", | |||
| buildGitRev: "d54b87ca0be09b678bb4490060e8f23f890ddb92", | |||
| buildGitBranch: "gitBranch", | |||
| goVersion: "1.18", | |||
| goVersion: "1.18.1", | |||
| goOS: "amiga", | |||
systay
approved these changes
Apr 15, 2022
deepthi
requested changes
Apr 15, 2022
frouioui
force-pushed
the
upgrade-to-go1.18.1
branch
from
8ebde5b
to
6e44f0e
Compare
frouioui
force-pushed
the
upgrade-to-go1.18.1
branch
from
6e44f0e
to
9bf8516
Compare
deepthi
approved these changes
Apr 15, 2022
frouioui
force-pushed
the
upgrade-to-go1.18.1
branch
from
9bf8516
to
ade1335
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
upgrade-to-go1.18.1
branch
from
ade1335
to
6ba3c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request upgrades the golang version used on
maintogo1.18.1. The Go team has recently released a new patch release forgo1.18that contains vulnerability fixes, that impact Vitess.Snippet from the Go release history website:
Note that the minimum required Go version is
1.18.1, if this requirement is not met, the following error will appear when building Vitess:Checklist