schemadiff: validate() table structure at the end of apply() #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Enhancement
dbussink
approved these changes
May 2, 2022
go/vt/schemadiff/table_test.go
Outdated
Comment on lines
749
to
754
| { | ||
| name: "drop column, break key", | ||
| from: "create table t (id int primary key, i int, key i_idx(i))", | ||
| alter: "alter table t drop column i", | ||
| expectErr: ErrInvalidColumnInKey, | ||
| }, |
There was a problem hiding this comment.
Right now this makes sense as a safeguard until we improve the drop column logic to also drop references from the index to mimic MySQL behavior.
There was a problem hiding this comment.
If we choose to go that path then I'll update this PR; no need to postpone that to a future PR.
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
… validate that Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…odify columns, then add columns, then add keys, ... Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
Tracking issue: #10203 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First PR of several. This PR kicks schema validation for a
CreateTableEntity. Some stuff we can validate delaratively; this PR validates that keys-to-columns relationship are valid. That is, that all columns referenced by keys do actually exist.