Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix flaky test via extended timeout in vrepl_stress_suite #10231

Merged

Conversation

shlomi-noach
Copy link
Contributor

Description

Discussion: #8969 (comment)

Gonna create this PR as Draft and run vrepl_stress_suite multiple times to see if this fixes the flakiness. The tests have been stable for months, and recently became flaky. First suspicion is GitHub CI runners getting slower.

Related Issue(s)

#8969 (comment)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

All right, ran the test 10 times and it always passed. this looks good to me, and it seems like GitHub CI just got slower and that we need longer timeouts. I'll look into other onlineddl tests and increase timeouts as needed.

Thanks to @mattlord who identifies the root cause of the failure.

@shlomi-noach shlomi-noach marked this pull request as ready for review May 8, 2022 16:43
@shlomi-noach
Copy link
Contributor Author

Ready to review, and not a moment too soon 😛

@shlomi-noach shlomi-noach requested a review from a team May 8, 2022 16:43
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@shlomi-noach shlomi-noach merged commit 87de856 into vitessio:main May 8, 2022
@shlomi-noach shlomi-noach deleted the fix-vrepl-stress-flaky-test branch May 8, 2022 17:13
mattlord added a commit to planetscale/vitess that referenced this pull request May 8, 2022
Signed-off-by: Matt Lord <mattalord@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants