Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] Further generalize DangerAction into ActionPanel #10323

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 17, 2022

Description

Further adventures in generalizing the DangerAction component! The original is very well-written + made these refactors nice and straightforward. :chef-kiss:

  • Renames the component from DangerAction to ActionPanel, and adds a danger prop to preserve the scary styling when necessary. 🎃
  • Updates all of the mutation triggers on the tablet/advanced page to use ActionPanel in its less scary form.
  • Makes the confirmation input optional.
  • Adds a disabled prop
  • Lots more tests

Using ActionPanel under the hood, everything works as before:

tablet-actions-2

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

doeg added 9 commits May 17, 2022 11:34
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg added 2 commits May 17, 2022 12:48
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg marked this pull request as ready for review May 17, 2022 16:50
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
loadingText="Starting Replication..."
mutation={startReplicationMutation as UseMutationResult}
title="Start Replication"
warnings={[primary && 'Command StartReplication cannot be run on the primary tablet.']}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this copy is currently:

Command StartTablet cannot be run on the primary tablet.

I think it should probably be (emphasis mine)

Command StartReplication cannot be run on the primary tablet.

... But wanted to call this out in case I'm missing something. Same deal with the StopTablet -> StopReplication copy change below.

@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎵 hiiiiiighhhhwaaaaayyyyy to theeeeee ActionPanel 🎵

@doeg doeg merged commit 883294d into vitessio:main May 17, 2022
@doeg doeg deleted the sarabee-generalize-danger-actions-once-more-with-feeling branch May 17, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants