-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtadmin] Further generalize DangerAction into ActionPanel #10323
[vtadmin] Further generalize DangerAction into ActionPanel #10323
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
loadingText="Starting Replication..." | ||
mutation={startReplicationMutation as UseMutationResult} | ||
title="Start Replication" | ||
warnings={[primary && 'Command StartReplication cannot be run on the primary tablet.']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this copy is currently:
Command StartTablet cannot be run on the primary tablet.
I think it should probably be (emphasis mine)
Command StartReplication cannot be run on the primary tablet.
... But wanted to call this out in case I'm missing something. Same deal with the StopTablet
-> StopReplication
copy change below.
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎵 hiiiiiighhhhwaaaaayyyyy to theeeeee ActionPanel
🎵
Description
Further adventures in generalizing the DangerAction component! The original is very well-written + made these refactors nice and straightforward. :chef-kiss:
DangerAction
toActionPanel
, and adds adanger
prop to preserve the scary styling when necessary. 🎃tablet/advanced
page to useActionPanel
in its less scary form.disabled
propUsing
ActionPanel
under the hood, everything works as before:Related Issue(s)
Checklist
Deployment Notes
N/A